fix(php): JSON serialize empty arrays as empty object #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/json--serialize-empty-arrays-as-object
amckinney
approved these changes
Feb 13, 2025
| * @param array $arr | ||
| * @return bool | ||
| */ | ||
| private static function isSequential(array $arr): bool { // @phpstan-ignore-line |
There was a problem hiding this comment.
phpstan wants array to have more information, but we don't have more info
There was a problem hiding this comment.
Actually, phpstan doesn't mind mixed[]
| $overrideProperties = $options['bodyProperties'] ?? []; | ||
| if(is_array($body) && self::isSequential($body)){ |
There was a problem hiding this comment.
nit: Let's tidy up the spacing on these:
Suggested change
| if(is_array($body) && self::isSequential($body)){ | |
| if (is_array($body) && self::isSequential($body)) { |
Comment on lines
195
to
201
| if(is_array($result)){ | ||
| $result = array_merge($result, $overrideProperties); | ||
| if(empty($result)){ | ||
| // force to be serialized as {} instead of [] | ||
| return (object)($result); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if(is_array($result)){ | |
| $result = array_merge($result, $overrideProperties); | |
| if(empty($result)){ | |
| // force to be serialized as {} instead of [] | |
| return (object)($result); | |
| } | |
| } | |
| if (is_array($result)){ | |
| $result = array_merge($result, $overrideProperties); | |
| if (empty($result)){ | |
| // force to be serialized as {} instead of [] | |
| return (object)($result); | |
| } | |
| } |
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
Swimburger
deleted the
niels/php/json--serialize-empty-arrays-as-object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSON serialize empty arrays as empty object
Changes Made
Testing