Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Make sure node.exe is executed. #5987

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(cli): Make sure node.exe is executed. #5987

merged 1 commit into from
Feb 14, 2025

Conversation

Koubek
Copy link

@Koubek Koubek commented Feb 13, 2025

Description

It looks like the changes are not correct, node.exe is probably not executed on Windows.

Changes Made

Executing node.exe explicitly.

Testing

  • Unit tests added/updated
  • Manual testing completed

@Koubek Koubek requested a review from dsinghvi as a code owner February 13, 2025 17:13
@Koubek Koubek changed the title Make sure node.exe is executed. fix: Make sure node.exe is executed. Feb 13, 2025
@Koubek Koubek changed the title fix: Make sure node.exe is executed. fix(cli): Make sure node.exe is executed. Feb 13, 2025
@Koubek
Copy link
Author

Koubek commented Feb 13, 2025 •
edited
Loading

@dsinghvi You can see here the CLI is executed correctly (sure, I am not logged-in but that's fine). I think your execution doesn't have any output which means it's really not executed at all.

@dsinghvi dsinghvi merged commit 774df75 into fern-api:dsinghvi/test-windows-docs-dev Feb 14, 2025
2 of 4 checks passed
dsinghvi pushed a commit that referenced this pull request Feb 14, 2025
@Koubek @dsinghvi
fix(cli): Make sure node.exe is executed. (#5987)
01de81e 
Make sure node.exe is executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koubek @dsinghvi