Compile time (packet ids, registries) stuff #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made packets use resource ids (
move_player_pos_rot
) instead of packet ids (0x01
) for both INCOMING (Serverbound) and OUTGOING (Clientbound) packets.OLD System:
#[packet(packet_id = 0x1B, state = "play")]
NEW System:
#[packet(packet_id = "move_player_pos_rot", state = "play")]
What's a resource id and how do I get it? 🤓 ☝️
You can get it from here, little timmy:
Step 1: Go to the Protocol website
Step 2: Look for a packet you want, e.g.:
Step 3: Look for resource name, in this case it'd be
cooldown
.Done.
Benefits: No hardcoding, version switching (ofcourse ignoring other problems like field orders, and state machine changes), is way easier. Just change the json file (generated via the datagenerator of 1.21.1 version
server.jar
), and recompile.This is compile time macros so it's basically equivalent to manually typing it yourself, runtime performance-wise.
Also there is a new
get_registry_entry!
macro, also compile time. It returns a specific ID from theregistries.json
, also generated by the datagenerator.Example usage:
DATA GENERATOR: https://minecraft.wiki/w/Minecraft_Wiki:Projects/wiki.vg_merge/Data_Generators
I had to manually replace all ids with the resource ids, 😔😔.
This is a lot of yap, where's my credits?