Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the packet sender sync #162

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Making the packet sender sync #162

merged 11 commits into from
Jan 21, 2025
+150 −181

Conversation

Sweattypalms
Copy link
Member

@Sweattypalms Sweattypalms commented Jan 16, 2025 •
edited
Loading

Description

Make packet sending sync to fix some deadlock issues

Motivation and Context

deadlock on single/multi thread

How has this been tested?

300+ joined players

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (restructuring code, without changing its behavior)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Clippy passes with no warnings.

@ReCore-sys ReCore-sys changed the title fix/make-packet-sending-sync Making the packet sender sync Jan 16, 2025
ReCore-sys
ReCore-sys requested changes Jan 17, 2025
View reviewed changes
Cargo.toml Show resolved Hide resolved
src/bin/src/main.rs Show resolved Hide resolved
src/lib/net/src/connection.rs Outdated Show resolved Hide resolved
@GStudiosX2 GStudiosX2 mentioned this pull request Jan 19, 2025
Open
@ReCore-sys ReCore-sys merged commit fe728a9 into master Jan 21, 2025
6 checks passed
@ReCore-sys ReCore-sys deleted the fix/make-packet-sending-sync branch January 21, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReCore-sys ReCore-sys ReCore-sys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sweattypalms @ReCore-sys