Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clean nix/nixos development enviroment #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eveeifyeve
Copy link

Check description.

Description

Adds a nix/nixos development with automation though github actions with

Motivation and Context

This change is required because there is currently no default dev enviroment for nix/nixos It solves having an environment to use when developing ferrum there was previously a pr for adding a flake below, but there was a couple problems one it uses flake utils which is a non module based system which means it makes it harder to make things compatible plus is a non nix way of doing, two building the package inside of the devshell is not really required as the user can run cargo build --release and then use the bin produced, three it tries to add back the cargo lock file which is only good if your producing a library but ferrumc is producing a binary so it's an unneeded file.

Follow up #125.

How has this been tested?

Local using direnv and nix develop as well as nix flake check plus I have also built in a flake check for each pr that is created.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (restructuring code, without changing its behavior)
  • Add repository changes

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Clippy passes with no warnings.

make flake check action check all systems

added assignment to assign myself to flake update prs.

fix actions to use determinsys

switch nix formatting check to flake check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant