Config simplification #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GStudiosX2
reviewed
Oct 26, 2024
| motd = ["Welcome to the server!", "Have a great time!", "Adventure awaits!"] # Message of the day | ||
| max_players = 100 # Maximum number of players | ||
| network_tick_rate = 20 # Network updates per second per user | ||
| world = "World" # The name of the world to load |
There was a problem hiding this comment.
Wasn't the previous value for this world = "world"?
There was a problem hiding this comment.
yes, but it doesn't really matter
There was a problem hiding this comment.
yes, but it doesn't really matter
Yeah I guess it's not used yet still think it should be the same as it was before though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying the config system
Description
The config system was overly complicated and contained a lot of clutter that made it difficult to decipher. This PR changes the config init system from a complex OnceLock system to a much more streamlined lazy_static system. The change from runtime init to a "life before main" system is minor since the config would be one of the first things set up anyway. The only major issue would be not being able to use tracing since that won't have been initialized yet.
The other change implemented was changing how the favicon is fetched, switching it from a runtime loading to simply using lazy_static to bake the favicon directly into the binary.
Motivation and Context
This PR makes the config much easier to work with and debug. It was discussed with members in the discord server.
How has this been tested?
It has been tested manually since unit tests of this nature would be largely incompatible with CI
Types of changes
Checklist: