Correct form and docstrings

festim-dev · Jul 9, 2024 · d481a88 · d481a88
1 parent 1add5fc
commit d481a88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/festim/boundary_conditions/fluxes/surface_kinetics.py b/festim/boundary_conditions/fluxes/surface_kinetics.py
@@ -13,8 +13,8 @@ class SurfaceKinetics(FluxBC):
 
     .. math::
 
-        -D \nabla c_\mathrm{m} \cdot \mathbf{n} = -\lambda_{\mathrm{IS}} \dfrac{\partial c_{\mathrm{m}}}{\partial t}
-        - J_{\mathrm{bs}} + J_{\mathrm{sb}},
+        -D \nabla c_\mathrm{m} \cdot \mathbf{n} = \lambda_{\mathrm{IS}} \dfrac{\partial c_{\mathrm{m}}}{\partial t}
+        + J_{\mathrm{bs}} - J_{\mathrm{sb}},
 
     where :math:`c_{\mathrm{m}}` is the concentration of mobile hydrogen (:math:`\mathrm{H \ m}^{-3}`),
     :math:`c_{\mathrm{s}}` is the surface concentration of adsorbed hydrogen (:math:`\mathrm{H \ m}^{-2}`),
@@ -163,7 +163,7 @@ def create_form(self, solute, solute_prev, solute_test_function, T, ds, dt):
                 )
                 # Flux to solute species
                 self.form += (
-                    -lambda_IS
+                    lambda_IS
                     * (solute - solute_prev)
                     / dt.value
                     * solute_test_function

diff --git a/test/unit/test_boundary_conditions.py b/test/unit/test_boundary_conditions.py
@@ -688,7 +688,7 @@ def J_vs(cs, T, prm1, prm2):
         (adsorbed - adsorbed_prev) / dt.value * adsorbed_test_function * ds(1)
     )
     expected_form += (
-        -lambda_IS * (solute - solute_prev) / dt.value * solute_test_function * ds(1)
+        lambda_IS * (solute - solute_prev) / dt.value * solute_test_function * ds(1)
     )
     expected_form += -(j_vs + J_bs - J_sb) * adsorbed_test_function * ds(1)
     expected_form += (J_bs - J_sb) * solute_test_function * ds(1)