Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non cartesian cases for simple diffusion and the soret effect #74

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rekomodo
Copy link
Collaborator

#64

Copy link
Contributor

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spherical cases can only be 1D
  • It could be worth adding a few details about the derivation in non-cartesian (mostly the expression of the divergence)
  • I think the MMS source isn't valid for the spherical case. I obtained $S = -6 D$ in the spherical system of coordinates
  • In the write up the exact solution is $1 + r^2$ but not in the code block
  • In cylindrical/spherical one cannot set a BC other than no flux on $r=0$ boundary because that would be a singularity. I think that in your case specifically, since the gradient is zero on this boundary it works well. But I would have the domain start at $r=1$.

@rekomodo
Copy link
Collaborator Author

rekomodo commented Aug 23, 2024

It could be worth adding a few details about the derivation in non-cartesian (mostly the expression of the divergence)

The same expression from the implementation right? I'll add it at the end.

@RemDelaporteMathurin RemDelaporteMathurin linked an issue Aug 26, 2024 that may be closed by this pull request
@rekomodo
Copy link
Collaborator Author

just rebased the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cylindrical and spherical verification cases
2 participants