-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non cartesian cases for simple diffusion and the soret effect #74
Draft
rekomodo
wants to merge
10
commits into
festim-dev:main
Choose a base branch
from
rekomodo:non_cartesian
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemDelaporteMathurin
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Spherical cases can only be 1D
- It could be worth adding a few details about the derivation in non-cartesian (mostly the expression of the divergence)
- I think the MMS source isn't valid for the spherical case. I obtained
$S = -6 D$ in the spherical system of coordinates - In the write up the exact solution is
$1 + r^2$ but not in the code block - In cylindrical/spherical one cannot set a BC other than no flux on
$r=0$ boundary because that would be a singularity. I think that in your case specifically, since the gradient is zero on this boundary it works well. But I would have the domain start at$r=1$ .
The same expression from the implementation right? I'll add it at the end. |
rekomodo
force-pushed
the
non_cartesian
branch
from
August 29, 2024 16:47
1167b8e
to
51bfe7d
Compare
just rebased the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64