feat: ASI supply replacement #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/asi-supply-replacement # Conflicts: # cmd/fetchd/cmd/genesis-asi-upgrade.go
Jonathansumner
changed the title
pbukva
reviewed
May 16, 2024
| curSupplyCoin := sdk.NewCoin(denomInfo.NewDenom, curSupply) | ||
|
|
||
| // add new coins to the current supply | ||
| newSupplyCoins := additionalSupplyCoin.Add(curSupplyCoin) |
There was a problem hiding this comment.
Just for consistency with add operation in line below, it would be better to swap operands in add operator:
Suggested change
| newSupplyCoins := additionalSupplyCoin.Add(curSupplyCoin) | |
| newSupplyCoins := curSupplyCoin.Add(additionalSupplyCoin) |
pbukva
reviewed
May 16, 2024
| @@ -50,6 +50,10 @@ var networkInfos = map[string]NetworkConfig{ | |||
| NewDenom: "aasi", | |||
| OldDenom: "afet", | |||
| }, | |||
| SupplyInfo: SupplyInfo{ | |||
| AdditionalSupplyValue: "100000000000000000000000000", // TODO(JS): likely amend this | |||
| UpdatedSupplyOverflowAddr: "fetch15p3rl5aavw9rtu86tna5lgxfkz67zzr6ed4yhw", // TODO(JS): likely amend this | |||
There was a problem hiding this comment.
If possible, I would suggest to use different term overflow, something like:
Suggested change
| UpdatedSupplyOverflowAddr: "fetch15p3rl5aavw9rtu86tna5lgxfkz67zzr6ed4yhw", // TODO(JS): likely amend this | |
| DestinationWalletForNewlyMintedSupply: "fetch15p3rl5aavw9rtu86tna5lgxfkz67zzr6ed4yhw", // TODO(JS): likely amend this |
There was a problem hiding this comment.
If this renaming would be done, it will have fallout effect on all places where the same naming convention was used.
pbukva
reviewed
May 16, 2024
| @@ -50,6 +50,10 @@ var networkInfos = map[string]NetworkConfig{ | |||
| NewDenom: "aasi", | |||
| OldDenom: "afet", | |||
| }, | |||
| SupplyInfo: SupplyInfo{ | |||
| AdditionalSupplyValue: "100000000000000000000000000", // TODO(JS): likely amend this | |||
… feat/asi-supply-replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionalSupplyValueto a hard-coded overflow address