-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl StableDeref for LocatedSpan #65
impl StableDeref for LocatedSpan #65
Conversation
Hi, Thanks for the PR! Some requests for the dependencies:
Also add a comment next to the trait impl (and optionally in Cargo.toml) to explain what this is about and why it's safe (a copy-paste of your commit message would be fine) |
LocatedSpan is largely just a wrapper around the contained type `T`, so this marker trait is safe to implement whenever T already implements StableDeref.
2c85930
to
6de5507
Compare
Thanks for the reply. I have updated the PR with your requested changes. |
thanks! |
Would you be open to tagging a release that includes this PR and publishing it? If I understand correctly this would only be a minor version bump. |
I'd like to merge #66 first |
👋 Friendly ping to ask for cutting a new minor release. |
changelog updated, and I forwarded the ping |
Thanks for your work (both of you). I'll do this tomorrow or monday. PS: I am very glad to see contributions and also proud and thankful that this project lives thanks to its community! |
Version 2.1.0 released! 🎉 |
I can't implement this marker trait in my own code due to the orphan rule, and it's a very broadly used marker trait and should be safe to implement here. The added dependency doesn't have any transitive dependencies and only contains the trait definitions + simple marker impls.