-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LocatedSpan::get_line(). #66
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a1e33fa
Implement LocatedSpan::get_line().
kaj c4df145
Add some tests.
kaj 65cf3e1
Remove bogus comment.
kaj 942d0c9
No need for get_line() to return Option.
kaj 060fd1f
The test that uses `format!` requires std.
kaj 1810ec3
Some rustfmt.
kaj 84ca913
Refactor two similar unsafe blocks to one.
kaj 6fb916a
Add some disclaimer comments / docs.
kaj 60ea6cb
Rename get_line to get_line_beginning.
kaj de713cb
Add line_begining_may_ot_be_entire_len test.
kaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the name doesn't make it clear what this does, but I can't think of a better one. :/
Also some comment to explain what it does would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I considered
get_original_size
, as that is pretty much the intent. But I didn't, since it has no way of reconstructing the original length. Sounoffsetted
is what it actually does, it undos the offset.As for the larger question about a possibly missing trailer of
get_line()
; Yes, I was a bit worried about that myself, but decided that it's not a big problem in my main use-case of reporting parse errors. In cases I can think of that involves marking an interval (and not just a position) of a line, I think I would have twoLocatedSpan
s to combine, where each of them would (probably) be "the rest of input from a starting point".But I agree that this should be explained somehow, both in i a comment at
get_unoffsetted_slice
and in the docstring ofget_line
. I'll try to write something.