Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example in readme see issue #92 #94

Merged
merged 3 commits into from
Dec 22, 2023
Merged

update example in readme see issue #92 #94

merged 3 commits into from
Dec 22, 2023

Conversation

pontussjostedt
Copy link
Contributor

Updates the example in README

@pontussjostedt
Copy link
Contributor Author

I am having trouble validating that the first example works aswell. There is no named! macro in nom or nom_locate after looking on docs.rs. Should the first example be removed/updated?

@pontussjostedt
Copy link
Contributor Author

pontussjostedt commented Dec 22, 2023

Not sure if I should bump the version in the changelog to version 4.2.1 and include the change in the same format as the other changes documented there.

@progval
Copy link
Collaborator

progval commented Dec 22, 2023

That's probably a leftover from an old nom

@progval
Copy link
Collaborator

progval commented Dec 22, 2023

Don't bother with the changelog, I update it myself when publishing a release

@pontussjostedt
Copy link
Contributor Author

That's probably a leftover from an old nom

So it should be removed then I assume. gimme a sec and I'll make another commit.

@progval
Copy link
Collaborator

progval commented Dec 22, 2023

Please update the example instead of removing it. The modern equivalent of named! is to define a regular function

@progval
Copy link
Collaborator

progval commented Dec 22, 2023

Thanks!

@progval progval merged commit 735a7b4 into fflorent:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants