This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
Fix expect() to properly raise exception #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expect()` description states the in case of timeout an exception is raised however it never is. This commit adds raising exception to 'expect()' and uses new TimeoutError (see PEP 3151).
sriramkannan95
approved these changes
Jun 19, 2024
|
yes，I modified the py in myself env like this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect()description states the in case of timeout an exception is raised however it never is. This commit adds raising exception to 'expect()' and uses new TimeoutError (see PEP 3151).