-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some cmalign subprocess udpates #8
Conversation
crosenth
commented
Jan 30, 2014
- quieting logging status messages
- piping cmalign output to logging
- defaulting cmalign # of cpus to 2
- added tmpdir argument for intermediate files
Hey Chris - thanks for this. A few thoughts, if it's not too annoying:
|
…call to Popen to gain control over cmalign output.
… funny as output. output should not be large so just reading all to memory is fine.
…the subprocess.wait() command with cmalign and futures. Causes deadlock.
|
The number of threads is overridden the only place pplacer is called (not that that's the best option); not so for cmalign. |
done |
More generally, I think it we should either a) keep the parallelism as is (one process per taxon/OTU) or b) split into threads and processes, cc @nhoffman |
Thanks Connor. So we don't lose your last comment, wanna copy it to Issues and assign it to me or Noah? |