WIP: add support for monthly billing details in excel format #139
Conversation
| @@ -37,6 +44,21 @@ func newBillingCmd(c *config) *cobra.Command { | |||
| Short: "manage bills", | |||
| Long: "TODO", | |||
| } | |||
| excelBillingCmd := &cobra.Command{ | |||
There was a problem hiding this comment.
should be a new output option, e.g. -o xlsx as for yaml and json.
There was a problem hiding this comment.
Not really, as it generates ALL available billing data in one excel file.
There was a problem hiding this comment.
But actually csv creation is done serverside (cloud-api)
| @@ -322,6 +352,422 @@ func (c *config) clusterUsageCSV(cur *models.V1ClusterUsageRequest) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *config) excel() error { | |||
There was a problem hiding this comment.
should be a printer not a command
There was a problem hiding this comment.
We could rename this to "all", but I'm not sure how to generate an output for everything in the other formats.
There was a problem hiding this comment.
json and yaml output is simply a serialization, table output is obviously a bit harder, can then be return a error like table output for all entities is not supported
There was a problem hiding this comment.
maybe even better instead of all a slice of entities which should be returned, e.g. cloudctl billing cluster,volume -o xlsx
| k8s.io/client-go v11.0.1-0.20190409021438-1a26190bd76a+incompatible // indirect | ||
| sigs.k8s.io/controller-runtime v0.8.3 // indirect | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
do not use 2 require stanzas
There was a problem hiding this comment.
for simpler error checking there is a must func provided
|
This is currently done on server side and thoroughly tested, having the same logic on the client side without tests is not a good idea an will lead to differences in both results and issues raised by customers. Closing. |
This PR adds a generator for monthly billing details in excel format