Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper event for syncing #84

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AbdelAbouhassane
Copy link

@AbdelAbouhassane AbdelAbouhassane commented Feb 12, 2022

Context

The Sync method uses behind the scenes first detach to detach all associations and then will use attachNew for each new entry, which leads to a lot of events being dispatched.

What did I do

  • Add syncing and synced events
  • Pass the results of sync to the dispatched event
  • Support both Laravel 8 and 9
  • Update README

@fico7489
Copy link
Owner

fico7489 commented Feb 6, 2023

we can add a new event, but all tests must pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants