Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Separate key pair to sign HC subnet consensus messages #210

Open
sergefdrv opened this issue Jun 20, 2022 · 1 comment
Open

Separate key pair to sign HC subnet consensus messages #210

sergefdrv opened this issue Jun 20, 2022 · 1 comment

Comments

@sergefdrv
Copy link
Contributor

For simplicity, HC subnet validators are currently governed by an AccountActor, not a miner actor, so there is only one pair of keys. However, storing owner's private keys on validator nodes doesn't seem good from security perspective. We should consider introducing worker keypairs for subnet validators to sign their consensus messages, similar to miner working keypairs.

@adlrocha
Copy link
Collaborator

I see two ways to approach this:

  • The same way we expect the multiaddress of a validator for certain consensus algorithms (see Mir) in Join() when joining a subnet, we could include the WorkerAddress as a mandatory argument to bind the owner addres of the validator (the main account actor for the validator) with a worker address. This would require adding some validator admin-specific functions to the subnet actor interface (but that's fine).
  • We modify the AccountActor, we use MinerActors to represent validator identities, or we create a brand new ValidatorActor, to support for worker addresses.

I personally prefer the former, as it doesn't require changes over builtin-actors, and using MinerActors for subnet validators seems like an overkill (we would only use the worker address feature from the whole implementation). I also think it gives us more flexibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants