Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audit section with reports for SnarkPack #1261

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Update audit section with reports for SnarkPack #1261

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a858c5e
Update audit section with reports for SnarkPack
nikkolasg May 31, 2021
5538b0b
Merge branch 'master' into nikkolasg-patch-1
ianconsolata Oct 31, 2024
b6b6ffa
Remove broken link to inaccessible security report
ianconsolata Oct 31, 2024
3dc12ae
Merge branch 'master' into nikkolasg-patch-1
ianconsolata Oct 31, 2024
6b7241d
Prettier format
ianconsolata Oct 31, 2024
4f85e6a
Fix husky pre-commit hook
ianconsolata Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions content/appendix/audit_reports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@ This audit covers the implementation of Filecoin's builtin Actors, focusing on t

## Proofs

### `2021-05-31` SnarkPack audit

Two externals audits have been contracted on the cryptographic part of [SnarkPack](https://eprint.iacr.org/2021/529.pdf), that is used in the [FIP0009](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0009.md):
- [Report](https://drive.google.com/file/d/1avwxOO6CK_nkX7AVV4P9l6XawNco3-m_/view) from [NCC group](https://www.nccgroup.com/us/)
ianconsolata marked this conversation as resolved.
Show resolved Hide resolved
- [Report](https://hackmd.io/@LIRa8YONSwKxiRz3cficng/B105no8w_) from Matteo Campanelli, a well known cryptography [researcher](https://www.binarywhales.com/)

One major issue was found in the report by Campanelli where the challenges of each prove commits were not tied to the aggregated proof; this could have led up to malicious miner forge valid aggregated proofs without the individual prove commits. The rest of the issues were of medium to informal severity.

### `2020-10-20` Filecoin Bellman and BLS Signatures

- Report: [**Filecoin Bellman/BLS Signatures Cryptography Review**](https://research.nccgroup.com/wp-content/uploads/2020/10/NCC_Group_ProtocolLabs_PRLB007_Report_2020-10-20_v1.0.pdf)
Expand Down