Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for dragging recent files #16716

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Navigated to recents list
  3. Tried dragging into other areas such as desktop/browser

By default, the file is moved to the target location, over being copied or linked.

@yaira2
Copy link
Member

yaira2 commented Jan 19, 2025

This looks like the same as #15555. Are the issues mentioned there resolved?

@Lamparter
Copy link
Contributor Author

This looks like the same as #15555. Are the issues mentioned there resolved?

Yes!

@Lamparter Lamparter requested a review from yaira2 January 19, 2025 09:58
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
yaira2
yaira2 previously approved these changes Jan 19, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 19, 2025
@yaira2
Copy link
Member

yaira2 commented Jan 19, 2025

Fyi @Krytan

var items = e.Items.OfType<RecentItem>().ToList();
var storageItems = new List<IStorageItem>();

foreach (var item in items)
Copy link
Member

@yaira2 yaira2 Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to just get the dragged item, we shouldn't need a for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for dragging recent files
2 participants