Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 attachments #67

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Base64 attachments #67

merged 9 commits into from
Dec 20, 2024

Conversation

Era-Dorta
Copy link
Collaborator

@Era-Dorta Era-Dorta commented Jun 18, 2024 •
edited
Loading

This is a rebase of #12 on top of the current master.

thielenf added 4 commits June 18, 2024 23:42
@thielenf @Era-Dorta
implement get_attachment()
68700d4
@thielenf @Era-Dorta
implement base64_attachments:
3522090 
Message.parse() takes `signal: SignalAPI` instance as parameter,
which allows us to call its new get_attachment() method.
As a result, the Message.parse() needs to be `async` now.
@thielenf @Era-Dorta
make all Message.parse() calls asynchronous
737aacf
@thielenf @Era-Dorta
add a test case for messages with attachments
cbea06f
@Era-Dorta Era-Dorta mentioned this pull request Jun 21, 2024
Merged
@Era-Dorta
Copy link
Collaborator Author

Hi @filipre , it's been a while but I got again some time to work on this. Let me know if there is anything else that I should do to get this and #70 merged.

@Era-Dorta Era-Dorta mentioned this pull request Oct 12, 2024
Closed
@Era-Dorta Era-Dorta merged commit f8dc961 into filipre:master Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Era-Dorta @thielenf