remedy missed ruff check/formats in 0.6.0 release #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonywu
commented
Mar 8, 2025
| @@ -108,13 +108,13 @@ def should_generate_image(self, training_spec: TrainingSpec) -> bool: | |||
| def get_current_validation_image_path(self, training_spec: TrainingSpec) -> Path: | |||
| output_path = Path(training_spec.saver.output_path) / DREAMBOOTH_PATH_VALIDATION_IMAGES | |||
| output_path.mkdir(parents=True, exist_ok=True) | |||
| path = output_path / Path(f"{self.iterator.num_iterations :07d}_{DREAMBOOTH_FILE_NAME_VALIDATION_IMAGE}.png") | |||
There was a problem hiding this comment.
this looks like a bug that introduces extra space, but is actually a no-op.
anyway, the only trouble it causes is drifting away from ruff format style expectations
Draft
|
@anthonywu Thanks for noticing and fixing this! Maybe my pre-commit hooks was not working as expected... Will reinstall to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to rebase #129 inpainting PR on the latest main, and running into lots of unrelated diffs, much of it just related to missed
make formatandmake checkcalls prior to merging #131.Getting this out of the way so we can move forward without having to heal the repo state from a feature-focused branch.