Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection embedding names #100

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix collection embedding names #100

merged 2 commits into from
Sep 30, 2024

Conversation

sebnapi
Copy link
Contributor

@sebnapi sebnapi commented Sep 28, 2024

The original problem was that

f"{prefix}_embedding_hf_{start_date}".replace("-", "_")

was not following the convention that two underscores seperate the start_date.

This can be easily refactored into the parent class and made more robust by utilizing the model_name, so that we never compare vectors between different embedding models and never find ourselves creating a oversight bug like this again.

@sebnapi sebnapi marked this pull request as draft September 28, 2024 22:22
@sebnapi sebnapi marked this pull request as ready for review September 29, 2024 14:47
@sebnapi
Copy link
Contributor Author

sebnapi commented Sep 29, 2024

These changes fixed the code for me.

@finaldie
Copy link
Owner

Thank you so much @sebnapi for consolidating all these and unified the logic (also make the HuggingFace part working).

I'll merge it and create a new tag soon 👍

@finaldie finaldie merged commit 3b2ece1 into finaldie:main Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants