CTOOLS-2: Set proxy config when address it not None, even if username… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and password are None. Add type hint for proxy_config in ApiConfiguration.
|
Please can you provide an example of using the Proxy features with this as a setting? |
AndrewNeudegg
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and password are None.
Add type hint for proxy_config in ApiConfiguration.
Pull Request Checklist
developbranchDescription of the PR
This PR removes a check from the get_api_configuration method which prevents proxy information from being passed to the ApiClient if there is no username or password provided for the proxy.