constructors to fix 321 #348
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 75.93% 76.02% +0.09%
==========================================
Files 78 78
Lines 6565 6586 +21
==========================================
+ Hits 4985 5007 +22
+ Misses 1580 1579 -1 ☔ View full report in Codecov by Sentry. |
| """ | ||
| Array(arr::Union{Fiber, SwizzleArray}) | ||
|
|
||
| Construct an array from a fiber or swizzle. May reuse memory, will usually densify the fiber. |
There was a problem hiding this comment.
seems like the implementation here can't ever re-use memory; is the "may reuse memory" here so that this could be optimized later?
There was a problem hiding this comment.
Finch stores multidimensional dense arrays as vectors, so without adding a reshaped array operator, only vectors can share memory. However, in the future I'm not sure if it will be possible to reshape arrays without creating a reshapedarray, so I thought I'd leave the possibility open. At the very least, I could add a case for dense vectors.
fixes #321 fixes #319