Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fsparse, etc. match definitions in Base #361

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

willow-ahrens
Copy link
Collaborator

fixes #356

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4ab588f) 75.73% compared to head (59cd244) 75.92%.

Files Patch % Lines
src/interface/fsparse.jl 78.78% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   75.73%   75.92%   +0.18%     
==========================================
  Files          80       80              
  Lines        6801     6811      +10     
==========================================
+ Hits         5151     5171      +20     
+ Misses       1650     1640      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willow-ahrens willow-ahrens merged commit c390952 into main Dec 23, 2023
8 checks passed
@willow-ahrens willow-ahrens deleted the wma/fix356 branch January 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsparse, etc. need to have identical interfaces to those in Base
1 participant