Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wma/rename fiber #367

Merged
merged 15 commits into from
Jan 9, 2024
Merged

Wma/rename fiber #367

merged 15 commits into from
Jan 9, 2024

Conversation

willow-ahrens
Copy link
Collaborator

fixes #301

@wraith1995
Copy link
Collaborator

Why Tensorr?

@willow-ahrens
Copy link
Collaborator Author

Array is taken by Base Julia

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (b83f306) 76.04% compared to head (7548507) 75.86%.

Files Patch % Lines
src/tensors/fibers.jl 71.42% 8 Missing ⚠️
src/interface/mapreduce.jl 50.00% 5 Missing ⚠️
src/tensors/levels/sparsevbllevels.jl 0.00% 5 Missing ⚠️
src/tensors/levels/separationlevel.jl 33.33% 4 Missing ⚠️
src/tensors/levels/elementlevels.jl 50.00% 3 Missing ⚠️
src/tensors/levels/repeatrlelevels.jl 50.00% 3 Missing ⚠️
src/tensors/levels/sparsebytemaplevels.jl 50.00% 3 Missing ⚠️
src/tensors/levels/sparsecoolevels.jl 50.00% 3 Missing ⚠️
src/tensors/levels/sparserlelevels.jl 0.00% 3 Missing ⚠️
src/traits.jl 40.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   76.04%   75.86%   -0.18%     
==========================================
  Files          81       81              
  Lines        6987     6965      -22     
==========================================
- Hits         5313     5284      -29     
- Misses       1674     1681       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willow-ahrens willow-ahrens merged commit e44fc29 into main Jan 9, 2024
8 checks passed
@willow-ahrens willow-ahrens deleted the wma/rename_fiber branch January 9, 2024 21:22
@willow-ahrens
Copy link
Collaborator Author

@teo I didn't understand that you were pointing out a typo, sorry! I pushed a quick fix on main

@wraith1995
Copy link
Collaborator

@willow-ahrens I thought there was a purpose to the other r? Maybe Tensor was taken!

@willow-ahrens
Copy link
Collaborator Author

Haha I thought you had made a typo, but I realized after I merged that the r was deliberate!

@willow-ahrens willow-ahrens mentioned this pull request Jan 13, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Rename Fiber to TensorTree or just Tensor
3 participants