Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleRLE level #373

Merged
merged 5 commits into from
Jan 13, 2024
Merged

SingleRLE level #373

merged 5 commits into from
Jan 13, 2024

Conversation

nullplay
Copy link
Collaborator

@nullplay nullplay commented Jan 11, 2024

fixes #329

@willow-ahrens
Copy link
Collaborator

What happens if you try to write two runs to the single run level?

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (c0c55fa) 75.88% compared to head (e6a8a5d) 75.96%.

Files Patch % Lines
src/tensors/levels/singlerlelevels.jl 76.50% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   75.88%   75.96%   +0.07%     
==========================================
  Files          81       82       +1     
  Lines        6983     7184     +201     
==========================================
+ Hits         5299     5457     +158     
- Misses       1684     1727      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nullplay
Copy link
Collaborator Author

What happens if you try to write two runs to the single run level?

It emits an error when thawed ptr is filled. https://github.com/willow-ahrens/Finch.jl/blob/018d4fb77e5c6da07c1af7bb7fb25c5c5c128a14/src/tensors/levels/singlerlelevels.jl#L310-L311

@willow-ahrens
Copy link
Collaborator

sounds great! I'll try this out when I get the chance.

@willow-ahrens
Copy link
Collaborator

I'm working on level docs, so I may ask you to add some docs for this once I'm done.

@nullplay
Copy link
Collaborator Author

I'm working on level docs, so I may ask you to add some docs for this once I'm done.

Sure!

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #375 merges with new documentation for levels, could you add the docs for this level in there? Also, please add tests for this. Other than that, this looks good!

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #375 merges with new documentation for levels, could you add the docs for this level in there? Also, please add tests for this. Other than that, this looks good!

@willow-ahrens
Copy link
Collaborator

sorry for the double review!

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willow-ahrens willow-ahrens merged commit 0ef7c16 into main Jan 13, 2024
8 checks passed
@willow-ahrens willow-ahrens deleted the jaeyeon/singlerle branch January 13, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single run level
2 participants