-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleRLE level #373
SingleRLE level #373
Conversation
What happens if you try to write two runs to the single run level? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 75.88% 75.96% +0.07%
==========================================
Files 81 82 +1
Lines 6983 7184 +201
==========================================
+ Hits 5299 5457 +158
- Misses 1684 1727 +43 ☔ View full report in Codecov by Sentry. |
It emits an error when thawed ptr is filled. https://github.com/willow-ahrens/Finch.jl/blob/018d4fb77e5c6da07c1af7bb7fb25c5c5c128a14/src/tensors/levels/singlerlelevels.jl#L310-L311 |
sounds great! I'll try this out when I get the chance. |
I'm working on level docs, so I may ask you to add some docs for this once I'm done. |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #375 merges with new documentation for levels, could you add the docs for this level in there? Also, please add tests for this. Other than that, this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #375 merges with new documentation for levels, could you add the docs for this level in there? Also, please add tests for this. Other than that, this looks good!
sorry for the double review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fixes #329