Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleList Level #374

Merged
merged 5 commits into from
Jan 13, 2024
Merged

SingleList Level #374

merged 5 commits into from
Jan 13, 2024

Conversation

nullplay
Copy link
Collaborator

@nullplay nullplay commented Jan 11, 2024

fixes #331

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (0ef7c16) 75.98% compared to head (aec6e5e) 75.70%.

Files Patch % Lines
src/tensors/levels/singlelistlevels.jl 64.43% 69 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   75.98%   75.70%   -0.29%     
==========================================
  Files          82       83       +1     
  Lines        7184     7380     +196     
==========================================
+ Hits         5459     5587     +128     
- Misses       1725     1793      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #375 merges with new documentation for levels, could you add the docs for this level in there? Also, please add tests for this. Other than that, this looks good!

Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willow-ahrens willow-ahrens merged commit 442b0a8 into main Jan 13, 2024
8 checks passed
@willow-ahrens willow-ahrens deleted the jaeyeon/singlelist branch January 13, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singleton level
2 participants