-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep Galley Plans Per Approximate Sparsity Pattern #679
Merged
Merged
Changes from 14 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5896d1a
add issimilar and get_cannonical_stats
7b69f89
cleanup
6761338
small fixes
4bbf23f
fix stats construction
092579c
last fix, definitely true this time
79d836d
fix NaiveStats constructor, again
2ed581d
small change to verbose passing
e835a12
fix deferred hash issue #664
4de8a9c
fix deferred equality check
85ac56e
Merge branch 'main' into kbd-make-galley-adaptive-to-inputs
willow-ahrens c53f9fb
Merge branch 'main' into kbd-make-galley-adaptive-to-inputs
willow-ahrens 354db43
Merge remote-tracking branch 'origin/main' into kbd-make-galley-adapt…
willow-ahrens b5b2831
more accurate benchmark
willow-ahrens 0c8ab41
add evaluation count to benchmark setup
willow-ahrens bff9d0d
rename GalleyExecutor to AdaptiveExecutor
5aa6d01
warn when the tag argument is given to the AdaptiveExecutor
816d974
remove with_scheduler issue
ffa437f
bug fix
cf19c69
lowering default threshold & warn on tag argument
d24a6af
update high-level benchmarks to set scheduler in setup
e31b572
Merge branch 'main' into kbd-make-galley-adaptive-to-inputs
kylebd99 5fd941b
small fix
f52839f
add compute overhead check
595f7b6
temporarily remove galley scheduler
910b033
add galley_scheduler back
1dbc64c
drop the warn on tag arg
bd2a62d
Merge branch 'main' into kbd-make-galley-adaptive-to-inputs
willow-ahrens fb7d3ca
Merge branch 'main' into kbd-make-galley-adaptive-to-inputs
willow-ahrens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like the GalleyExecutor to have a configurable statistics similarity threshold, and to store the caches for each threshold and statistics type separately.
Also, I'd like to choose different executors for different compilation strategies (rather than using a sentinel tag value). Perhaps we can use the current executor for the "use first input strategy", and the GalleyExecutor for the "similar inputs" strategy. Then the GalleyExecutor wouldn't need a tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already caches it per-statistics type, and I can do the same for the threshold by making it a member of the struct. Will do that.
I like this idea. It seems clearer. In this case, we need better names. Maybe we call this one "AdaptiveExecutor" and the other one "TagExecutor"? And only schedulers which rely on statistics will be valid choices for the "AdaptiveExecutor".
I'll make these changes.