Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wma/shard levels #697

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Wma/shard levels #697

wants to merge 28 commits into from

Conversation

willow-ahrens
Copy link
Collaborator

Add ShardLevels and rework parallelism in Finch

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] reported by reviewdog 🐶

VirtualShardLevel(device_2, lvl_2, sym, ptr, task, val, typeof(level_fill_value(Lvl)), Device, Lvl, Ptr, Task, Val)


[JuliaFormatter] reported by reviewdog 🐶

virtual_level_resize!(ctx, lvl::VirtualShardLevel, dims...) = (lvl.lvl = virtual_level_resize!(ctx, lvl.lvl, dims...); lvl)


[JuliaFormatter] reported by reviewdog 🐶

push_preamble!(ctx, quote


[JuliaFormatter] reported by reviewdog 🐶

end)
push_epilogue!(ctx, quote


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

push_preamble!(ctx,


[JuliaFormatter] reported by reviewdog 🐶

lvl_2 = virtualize(ctx_2, :($(lvl.ex).val[$(ctx_2(get_task_num(get_task(ctx_2))))]), lvl.Lvl) #TODO should this virtualize the eltype of Val?


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

push_preamble!(ctx, quote
Finch.resize_if_smaller!($(lvl.task), $(ctx(pos_stop)))
Finch.resize_if_smaller!($(lvl.ptr), $(ctx(pos_stop)))
Finch.fill_range!($(lvl.task), $(ctx(pos_start)), $(ctx(pos_stop)), 0)
end)


[JuliaFormatter] reported by reviewdog 🐶

return Thunk(
body = (ctx) -> begin


[JuliaFormatter] reported by reviewdog 🐶

return Thunk(
body = (ctx) -> begin


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

$(contain(ctx_2->assemble_level!(ctx_2, lvl.lvl, value(qos_fill, Tp), value(qos_stop, Tp)), ctx))


[JuliaFormatter] reported by reviewdog 🐶

body = (ctx) -> VirtualHollowSubFiber(lvl.lvl, value(qos), dirty),


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/src/docs/internals/parallel.md Outdated Show resolved Hide resolved
docs/src/docs/internals/parallel.md Show resolved Hide resolved
src/architecture.jl Outdated Show resolved Hide resolved
src/architecture.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
willow-ahrens and others added 3 commits February 5, 2025 19:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
src/tensors/levels/shard_levels.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant