Added properties based on NWS documentation #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this patch deletes (You didn't mention removing any properties) |
rct
reviewed
Nov 15, 2024
| tmp_dict["Onset"] = alert["properties"]["onset"] | ||
| tmp_dict["Expires"] = alert["properties"]["expires"] | ||
| tmp_dict["Ends"] = alert["properties"]["ends"] | ||
| tmp_dict["AreasAffected"] = alert["properties"]["areaDesc"] | ||
| tmp_dict["Description"] = alert["properties"]["description"] | ||
| tmp_dict["Instruction"] = alert["properties"]["instruction"] |
There was a problem hiding this comment.
This property got deleted. Was it intentional?
There was a problem hiding this comment.
This was a mistake. I've been out of pocket for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to NWS documentation and found a few more properties that some may find useful, especially the
Urgencyproperty.The documentation I referenced is here:
https://www.weather.gov/documentation/services-web-api#/default/alerts_active_zone
I have tested the changes locally and have even incorporated them into my system using HaKafkaNet of which I am the author.