fix: regex escaping in repo model

finos · May 5, 2024 · c5e8659 · c5e8659
1 parent 360c7c7
commit c5e8659
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/model/Repo.js b/src/model/Repo.js
@@ -1,6 +1,5 @@
 // Regex inspector - https://www.debuggex.com/
-// eslint-disable-next-line no-useless-escape
-const GIT_URL_REGEX = new RegExp("^(https)://(github\.com|gitlab\.com)/([a-zA-Z0-9\-\.]+)/([a-zA-Z0-9\-]+)(\.git)(/)?$");
+const GIT_URL_REGEX = new RegExp("^(https)://(github\\.com|gitlab\\.com)/([a-zA-Z0-9\\-\\.]+)/([a-zA-Z0-9\\-]+)(\\.git)(/)?$");
 
 /** Class representing a Repo. */
 class Repo {

diff --git a/test/testRepoModel.js b/test/testRepoModel.js
@@ -34,6 +34,8 @@ describe('model', async () => {
         null,
         "https://github.com/finos/proxy",
         "http://github.com/finos/git-proxy.git",
+        "https://github..com/finos/git-proxy.git",
+        "https://github.com/finos/git-proxy..git",
         "https://bitbucket.com/finos/git-proxy.git",
         "https://github/Citi/citi-ospo.git",
         "https://github.com/RBC/finos-traderX.git//"