fix(server): improved packfile encoding to support short messages and…

[sammoorhouse]

… unicode in errors

This change allows you to say

step.setError(`🥺 Rejecting repo ${action.repo} not in the authorisedList`);

in a step.

Also fixes a padding bug that meant fewer than 5chars of errors broke the proxy response.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sammoorhouse / name: Sam Moorhouse (8418ec3, 16586f1)
• ✅ login: JamieSlome / name: Jamie Slome (75ea989, 482d381, d2d2c6b)

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	d2d2c6b
🔍 Latest deploy log	https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/65c2513f9ecbe20008e7102c

[maoo]

Thanks for the PR @sammoorhouse ! Please reach out to [email protected] if you encounter any issue to sign the FINOS CLA using EasyCLA.

[JamieSlome]

@sammoorhouse - thanks for the contribution 👍 I'd been wondering how to get some "prettier" messages into the CLI for the developer.

Do you think we could include a test case with this PR to demonstrate it works successfully? Perhaps to demonstrate that a message successfully returns with Unicode characters?

Happy to help if needed 🎉

[sammoorhouse]

Thanks @JamieSlome I'll have a look later today!

[sammoorhouse]

I extracted 'handleMessage' in proxy/routes and wrote two tests just for that function in a second commit just now. Thanks!

[psmulovics]

Can someone kick the build again? It failed on something unrelated imho.

[coopernetes]

Can someone kick the build again? It failed on something unrelated imho.

The failure is due to #213, we have some sort of repo permission bug in the coverage steps.

I’ll try to get a PR open soon to get it fixed then we can rebase on this one. Seems like a simple enough fix: zgosalvez/github-actions-report-lcov#150

[JamieSlome]

LGTM! 🍰

Ready to go once we've addressed the code coverage permissions issue...

(cc) @coopernetes @CyberCitizen01