Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use codecov for test coverage reports #429

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

coopernetes
Copy link
Contributor

@coopernetes coopernetes commented Jan 30, 2024

Fixes: #430

Related: #203

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit fc86cf4
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/65c2425fa1bd550008ed725a

@coopernetes coopernetes force-pushed the bugfix/ci-permissions branch 2 times, most recently from cd5df09 to 4496d2c Compare January 30, 2024 18:59
@coopernetes coopernetes marked this pull request as ready for review January 30, 2024 19:23
@coopernetes coopernetes changed the title fix: more permission into workflow fix: use codecov for test coverage reports Feb 2, 2024
@JamieSlome JamieSlome added the bug Something isn't working label Feb 3, 2024
.github/workflows/nodejs.yml Show resolved Hide resolved
src/db/index.js Show resolved Hide resolved
Copy link

codecov bot commented Feb 5, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@JamieSlome
Copy link
Member

@coopernetes - once we've got the branch updated, I think we are good to merge?

trying out the codecov action

pin to latest 3.x version

feat: commit to trigger coverage report
@coopernetes
Copy link
Contributor Author

@JamieSlome good to go for final review & merge.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit d04ceda into finos:main Feb 6, 2024
10 checks passed
@coopernetes coopernetes deleted the bugfix/ci-permissions branch February 7, 2024 16:12
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
fix: use codecov for test coverage reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bugfix: fix test coverage reporting on PRs
3 participants