-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config schema #526
fix: config schema #526
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 64.23% 64.69% +0.45%
==========================================
Files 40 40
Lines 1191 1198 +7
==========================================
+ Hits 765 775 +10
+ Misses 426 423 -3 ☔ View full report in Codecov by Sentry. |
@msagi - I think we should make it such that we validate the config prior to starting the service. |
@msagi - can we create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Would like to get @coopernetes eyes on this as he pulled together this initial process 👍
fix: config schema
Fix for #509.
@JamieSlome: should GitProxy always validate the config file when starting? It seems it only runs the validation if -v/--validate is present.