feat: allow for providing an alternative domain for the proxy #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
06kellyjac
commented
Oct 17, 2024
•
06kellyjac
commented
- feat: allow for providing an alternative domain for the proxy
- Have the service report back the proxyURL for each project, rather than
- being embedded inside the frontend bundle.
- Concequence is duplicating some data but very minor and allows for us to serve
- different projects from different proxies in the future.
- Removed unused vite env var, added method to pull service's current path and substitute
- in the http proxy port. Works for local dev, should maintain current behaviour.
- Custom domain can be applied via optional config.
- New config value added to the config schema.
- Config schema documentation has been regenerated (including some other absent items).
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 60.08% 60.23% +0.14%
==========================================
Files 46 47 +1
Lines 1631 1647 +16
==========================================
+ Hits 980 992 +12
- Misses 651 655 +4 ☔ View full report in Codecov by Sentry. |
JamieSlome
reviewed
Oct 18, 2024
06kellyjac
force-pushed
the
allow_custom_proxy_domain
branch
from
6517407
to
f3494ce
Compare
JamieSlome
reviewed
Oct 25, 2024
|
@06kellyjac - what would you recommend in terms of version bump, patch or minor? |
|
With a new capability I'd say minor 👍 |
Have the service report back the proxyURL for each project, rather than being embedded inside the frontend bundle. Concequence is duplicating some data but very minor and allows for us to serve different projects from different proxies in the future. Removed unused vite env var, added method to pull service's current path and substitute in the http proxy port. Works for local dev, should maintain current behaviour. Custom domain can be applied via optional config. New config value added to the config schema. Config schema documentation has been regenerated (including some other absent items).
06kellyjac
force-pushed
the
allow_custom_proxy_domain
branch
from
0c80523
to
5c3dfe3
Compare
JamieSlome
approved these changes
Oct 31, 2024
Psingle20
pushed a commit
to Psingle20/git-proxy
that referenced
this pull request
Nov 27, 2024
feat: allow for providing an alternative domain for the proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.