Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: selectively disable TLS #781

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: selectively disable TLS #781

wants to merge 8 commits into from

Conversation

YongNotYoung
Copy link

closes #658

  • feat: add tls object - set enabled flag to bypass certs in proxy
  • chore: update config test to account for tls change

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 2419baa
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/674bcb5ca54a3f0008db0288
😎 Deploy Preview https://deploy-preview-781--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the fix label Nov 5, 2024
@JamieSlome
Copy link
Member

@YongNotYoung - great PR 👍

Are you able to sign the CLA via EasyCLA and we can get this merged?

JamieSlome
JamieSlome reviewed Nov 8, 2024
View reviewed changes
src/config/index.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there has been a bit of a merge conflict on this file. We want to ensure we keep everything plugins related 👍

JamieSlome
JamieSlome reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰 Just need to resolve the merge conflict in src/config/index.js.

@coopernetes - would be good to get your eyes on this as well.

@YongNotYoung
Copy link
Author

@YongNotYoung - great PR 👍

Are you able to sign the CLA via EasyCLA and we can get this merged?

Hey @JamieSlome, thanks for the review

We need to sort out some admin stuff before we'll be able to sign the CLA, but once we get it done, we'll be able to sign it and push the fixes for the merge conflicts

coopernetes
coopernetes requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggested change. Merge conflict needs to be resolved to preserve the plugins configuration property.

proxy.config.json Outdated Show resolved Hide resolved
@coopernetes
Copy link
Contributor

@YongNotYoung can you please resolve the conflicts on package-lock.json? Then this is good to merge 👍

@coopernetes coopernetes self-requested a review December 1, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieSlome JamieSlome JamieSlome left review comments

@coopernetes coopernetes Awaiting requested review from coopernetes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selectively disable TLS
4 participants
@YongNotYoung @JamieSlome @coopernetes @mgiancola9