Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a CI workflow to catch errors in the build and coding #1176

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
82 changes: 82 additions & 0 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
name: Node.js CI
on:
push:
branches: [main]
pull_request:
branches: [main]
jobs:
# building project
build:
name: Build
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [18.x]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v4

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Cache NPM
uses: actions/cache@v3
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Cache Elm
uses: actions/cache@v3
with:
path: ~/.elm
key: ${{ runner.os }}-elm-${{ hashFiles('**/elm.json') }}
restore-keys: |
${{ runner.os }}-elm-

- name: Download dependencies
run: npm ci

- name: Build
run: npm run build --if-present

- name: Running Test
run: npm test

# CVE scanning
cvescan:
name: CVE Scanning
runs-on: ubuntu-latest
needs: [build]
strategy:
matrix:
node-version: [18.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npx --yes auditjs ossi --whitelist allow-list.json

# Semgrep static code analysis
semgrep:
name: Semgrep
runs-on: ubuntu-latest
needs: [cvescan]
container:
# A Docker image with Semgrep installed. Don't change this.
image: returntocorp/semgrep
# Skip any PR created by dependabot to avoid permission issues
if: (github.actor != 'dependabot[bot]')
steps:
- uses: actions/checkout@v4
- run: semgrep scan --config auto --severity ERROR
env:
SEMGREP_APP_TOKEN: ${{ secrets.SEMGREP_APP_TOKEN }}
15 changes: 9 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,19 @@ morphir-test-coverage.json
generated/
out/
redistributable/Scala
cli/web/insightapp.js
cli/treeStuff.js
cli/index.html
cli2/lib/
packages/cli/web/insightapp.js
packages/cli/treeStuff.js
packages/cli/index.html
packages/incremental-compiler/lib/
packages/tests-integration/reference-model/Dockerfile
packages/cadl-Frontend/cadl-output
lib/geneated
cadl-Frontend/cadl-output
Morphir.Elm.CLI.js
Morphir.Elm.Generator.js
docs.json
/.coverage/
tests-integration/reference-model/Dockerfile

# Scala Related
.scala-build/
.bsp/
.bloop/
1 change: 1 addition & 0 deletions .mill-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0.11.12
56 changes: 56 additions & 0 deletions build.sc
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import $meta._
import $ivy.`io.github.alexarchambault.mill::mill-native-image::0.1.26`
import io.github.alexarchambault.millnativeimage.NativeImage

import mill.main.RootModule
import mill._, mill.scalalib._

object root extends RootModule {

def isCI = T.input {
val result = sys.env.getOrElse("CI", "false")
Seq("true","1","yes").contains(result)
}

def gulp(steps: String*) = T.command {
for (step <- steps) {
println(s"Running gulp $step")
}
}

def npmInstall() = T.command {
val installSubCommand = isCI() match {
case true => "ci"
case false => "install"
}
os.proc("npm", installSubCommand).call()
}

def setup() = T.command {
npmInstall()
}

object morphir extends Module {
object lang extends Module {
object elm extends ScalaProject{}
}
}

object ci extends RootModule {

}



trait ScalaProject extends ScalaModule {
def scalaVersion = V.Scala.defaultScalaVersion
}
}


object V {
object Scala {
val scala3x = "3.3.3"
val defaultScalaVersion = scala3x
}
}
7 changes: 0 additions & 7 deletions elm-tooling.json

This file was deleted.

3 changes: 2 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ testMorphirIR = series(


const test =
parallel(
series(
testUnit,
testIntegration,
// testMorphirIR,
Expand All @@ -454,6 +454,7 @@ exports.buildCLI2 = buildCLI2;
exports.compileMain2Ts = compileMain2Ts;
exports.build = build;
exports.test = test;
exports.testUnit = testUnit;
exports.csvfiles = csvfiles;
exports.testIntegration = testIntegration;
exports.testIntegrationSpark = testIntegrationSpark;
Expand Down
Loading