fix #151 adding Basics.logBase and Basics.e to morphir-sdk #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttilaMihaly
requested changes
Oct 6, 2023
| @inline def logBase(base: Float, number: Float): Float = | ||
| divide(scala.math.log(number))(scala.math.log(base)) | ||
| @inline def e(a: Float): Float = | ||
| scala.math.exp(a) |
There was a problem hiding this comment.
This doesn't look right. e just returns a number in Elm: https://package.elm-lang.org/packages/elm/core/latest/Basics#e
There was a problem hiding this comment.
Math.E looks like the right thing to use here: https://docs.oracle.com/javase/8/docs/api/java/lang/Math.html#E
There was a problem hiding this comment.
Okay @AttilaMihaly, I will make the necessary changes.
There was a problem hiding this comment.
@AttilaMihaly Just I mistook e() for exp() math function
stephengoldbaum
approved these changes
Oct 19, 2023
AttilaMihaly
approved these changes
Oct 26, 2023
|
@AttilaMihaly, the checks seen to fail at Basics.power() for float type. I intend to change it. I am thinking of using java's Math.pow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.