Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #1185

Closed
wants to merge 3 commits into from
Closed

Update Package.swift #1185

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa5783d
Update Package.swift
ArturoLee Mar 29, 2024
4f9b046
Update Podfile
ArturoLee Apr 1, 2024
300ddd3
chore: pod update FirebaseFacebookAuthUI
ArturoLee Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseFacebookAuthUI/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ target 'FirebaseFacebookAuthUI' do
# The facebook pods generate an unreasonable number of warnings.
inhibit_all_warnings!

pod 'FBSDKLoginKit', '~> 16.0'
pod 'FBSDKLoginKit', '~> 17.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run pod update in this directory to fix the build issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran pod update but it still didn't pass. I think it is because the library is using some deprecated methods.

  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseAuthUI/Sources/FUIAccountSettingsOperationUpdateEmail.m:80:37: warning: 'updateEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. Use sendEmailVerification(beforeUpdatingEmail email: String) instead. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailEntryViewController.m:151:14: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailAuth.m:524:21: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailAuth.m:646:21: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]

pod 'FBSDKCoreKit'

pod 'FirebaseAuthUI', :path => '../'
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ let package = Package(
.package(
name: "Facebook",
url: "https://github.com/facebook/facebook-ios-sdk.git",
"11.0.0"..<"17.0.0"
"11.0.0"..<"18.0.0"
),
.package(
name: "Firebase",
Expand Down
Loading