Automatically add trace property to v2 function logs #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
changed the title
taeold
changed the title
|
Trace property is not automatically added to logger.write(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All traffic to Cloud Run revisions are populated with
traceparentandX-Cloud-Trace-Contextheader doc and Functions Framework helpfully processes and injects the traceparent on cloudevent payload (See GoogleCloudPlatform/functions-framework#47).We take advantage of this and automatically inject
traceproperty to all logs generated fromfunctions.logger. All logs emitted from functions logger then are correlated with requests - and it even works when concurrency > 1.Traced logs are awesome with Cloud Logging:
And looks great in Cloud Trace too!