Add a test for whether unregistered listeners are called. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
added
the
tests-requested: quick
jonsimantov
removed
the
tests-requested: quick
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit refs/pull/618/merge
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if you unregister a listener from a given DatabaseReference, it will correctly stop calling that listener.
But if you unregister a listener from a different instance of DatabaseReference that happens to point to the same path, it will continue to call the listener. (Because it's not considered the same object.)
This test shows that issue - it should not be merged unless the issue is either fixed or the failing test is disabled.
Testing
Integration tests.
Type of Change
Place an
xthe applicable box: