Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples to use the new recordException overload. #596

Merged
merged 15 commits into from
Jan 20, 2025
Merged

Add examples to use the new recordException overload. #596

merged 15 commits into from
Jan 20, 2025

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Nov 21, 2024

@tejasd tejasd marked this pull request as draft November 29, 2024 21:50
@tejasd tejasd requested a review from mrober December 13, 2024 17:36
@tejasd tejasd marked this pull request as ready for review January 6, 2025 16:23
@tejasd tejasd requested a review from thatfiredev January 17, 2025 16:38
@tejasd
Copy link
Contributor Author

tejasd commented Jan 17, 2025

I've verified it locally using ./gradlew crashlytics:app:assembleDebug

thatfiredev
thatfiredev approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thatfiredev
Copy link
Member

The CI error seems to be unrelated to your PR. I have created #602 to investigate it.
Feel free to merge the PR even with the failing CI.

@tejasd tejasd enabled auto-merge (squash) January 20, 2025 17:00
@tejasd tejasd merged commit 28a69f2 into master Jan 20, 2025
6 checks passed
@tejasd tejasd deleted the td/record-exception branch January 20, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatfiredev thatfiredev thatfiredev approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejasd @thatfiredev @mrober