Better error management in verifiable secret sharing

fireblocks · Nov 26, 2024 · ac6b6bc · ac6b6bc
1 parent e932d0c
commit ac6b6bc
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/common/crypto/shamir_secret_sharing/verifiable_secret_sharing.c b/src/common/crypto/shamir_secret_sharing/verifiable_secret_sharing.c
@@ -601,8 +601,11 @@ void verifiable_secret_sharing_free_shares(verifiable_secret_sharing_t *shares)
     if (shares)
     {
         free(shares->ids);
-        OPENSSL_cleanse(shares->shares, shares->num_shares * sizeof(shamir_secret_sharing_scalar_t));
-        free(shares->shares);
+        if (shares->shares)
+        {
+            OPENSSL_cleanse(shares->shares, shares->num_shares * sizeof(shamir_secret_sharing_scalar_t));
+            free(shares->shares);
+        }
         free(shares->proofs);
         free(shares->coefficient_proofs);
         free(shares);