feat: FIR-44128 report column types in go sdk #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
|
| decimalPrefix = "Decimal(" | ||
| numericPrefix = "numeric(" | ||
| structPrefix = "struct(" | ||
| suffix = ")" |
There was a problem hiding this comment.
the suffix name seems a little vague when seen in code, could you rename it to something like complexTypeSuffix or closingBracketSuffix?
ptiurin
reviewed
Mar 5, 2025
|
|
||
| type fireboltType struct { | ||
| goType reflect.Type | ||
| dbName string |
There was a problem hiding this comment.
I'd call this dbType or it might be confused with database name.
Comment on lines
+66
to
+69
| if r.columns[index].fbType.precision > 0 && r.columns[index].fbType.scale > 0 { | ||
| return r.columns[index].fbType.precision, r.columns[index].fbType.scale, true | ||
| } | ||
| return 0, 0, false |
There was a problem hiding this comment.
I think there's a valid case when scale is 0, but precision is > 0. Redundant obviously, as it would be better represented by a different type, but nevertheless could occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types reporting for both inMemory and streaming rows.
For every column we now report