Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features: sync with agave #1700

Merged
merged 1 commit into from
May 30, 2024
Merged

features: sync with agave #1700

merged 1 commit into from
May 30, 2024

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented May 1, 2024

Updated feature gates to stay in sync with agave:

  • Update list
  • Mark "reverted":1 the features that got deleted (never activated)

Update timely_vote_credits pubkey. Context: anza-xyz/agave#127
Left as independent issue: #1906

@0x0ece 0x0ece force-pushed the 0x0ece/features branch 3 times, most recently from 6788329 to 11d08dd Compare May 2, 2024 01:20
@jumpsiegel
Copy link
Contributor

https://github.com/firedancer-io/firedancer-testbins/blob/0244dfb24d21b529eca17b543cfcfdc819d565ae/2/generated/test_native_programs_000.h#L23

We cannot reorganize/cleanup this file without regenerating the native program tests... My suggestion is to try to limit the scope of the changes to the feature_map to changing the public keys and adding new things at the end

@0x0ece 0x0ece force-pushed the 0x0ece/features branch 7 times, most recently from b1161aa to 3dfa483 Compare May 2, 2024 15:46
@0x0ece 0x0ece requested a review from topointon-jump May 2, 2024 16:23
@0x0ece 0x0ece force-pushed the 0x0ece/features branch from 3dfa483 to e9b572f Compare May 2, 2024 17:57
@0x0ece 0x0ece requested a review from jumpsiegel May 2, 2024 17:58
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a way of distinguishing between "cleaned up" (removed after activation - hardcoded to default activated) and "removed" (anza has reverted the code for these features, and never activated them, so they are no longer even present in anza's feature gate list).

src/flamenco/features/feature_map.json Outdated Show resolved Hide resolved
src/flamenco/features/feature_map.json Outdated Show resolved Hide resolved
@0x0ece 0x0ece force-pushed the 0x0ece/features branch 2 times, most recently from 137e2b9 to 70c671c Compare May 3, 2024 15:16
@0x0ece 0x0ece force-pushed the 0x0ece/features branch 2 times, most recently from c990127 to 2f3687c Compare May 10, 2024 16:04
@0x0ece 0x0ece force-pushed the 0x0ece/features branch from 0138f59 to 9eb7cf5 Compare May 17, 2024 19:26
jumpsiegel
jumpsiegel previously approved these changes May 17, 2024
@0x0ece 0x0ece enabled auto-merge May 17, 2024 19:54
ripatel-fd
ripatel-fd previously approved these changes May 17, 2024
@ripatel-fd ripatel-fd dismissed topointon-jump’s stale review May 17, 2024 20:58

changes addressed

@0x0ece 0x0ece added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@ripatel-fd
Copy link
Contributor

@lheeger-jump please fix CI

@ripatel-fd ripatel-fd added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@jumpsiegel jumpsiegel added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@ripatel-fd
Copy link
Contributor

+ find dump/test-vectors/instr/fixtures -type f -name '*.fix' -exec ./build/linux/gcc/icelake/unit-test/test_exec_instr '{}' +
++ grep -w FAIL build/linux/gcc/icelake/log/fd-test-vectors-report/test_vectors_exec
++ wc -l
+ failed=8
Total failed: 8
test vector execution failed

@0x0ece

@0x0ece 0x0ece force-pushed the 0x0ece/features branch 2 times, most recently from 85c34cb to de0f38a Compare May 22, 2024 13:50
@jumpsiegel jumpsiegel dismissed stale reviews from ripatel-fd and themself via a79009f May 29, 2024 14:03
@jumpsiegel jumpsiegel marked this pull request as draft May 29, 2024 14:11
@jumpsiegel jumpsiegel marked this pull request as ready for review May 30, 2024 12:34
@jumpsiegel jumpsiegel added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit a6bd74a May 30, 2024
12 checks passed
@jumpsiegel jumpsiegel deleted the 0x0ece/features branch May 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants