flamenco: add missing feature flag check for 0 signatures in secp256k1 verify #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbhargava-jump
previously approved these changes
Aug 28, 2024
mjain-jump
force-pushed
the
mjain/fix-precompile-bug
branch
2 times, most recently
from
bae03a9 to
861b9df
Compare
mjain-jump
force-pushed
the
mjain/fix-precompile-bug
branch
from
861b9df to
2855dc1
Compare
kbhargava-jump
approved these changes
Aug 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@samkim-crypto @seanyoung what do you think about cleaning up these old features? |
|
Good idea. I created anza-xyz/agave#2795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing feature flag check when calling secp256k1 verify