Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDP IO and Netlink rewrite #4141

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

XDP IO and Netlink rewrite #4141

wants to merge 11 commits into from

Conversation

ripatel-fd
Copy link
Contributor

@ripatel-fd ripatel-fd commented Feb 8, 2025 •
edited
Loading

  • XDP IO rewrite in net tile
  • New netlink tile + integration into net tile
  • Remove old XDP IO code
  • Remove old netlink code

This is a combination of #4135 and #4049. Please don't merge

@ripatel-fd ripatel-fd marked this pull request as ready for review February 8, 2025 11:11
@ripatel-fd ripatel-fd mentioned this pull request Feb 8, 2025
Closed
mmcgee-jump
mmcgee-jump reviewed Feb 8, 2025
View reviewed changes
src/app/fdctl/run/tiles/fd_net.c
uchar const * packet = (uchar const *)xsk->umem.addr + frame.addr;
net_rx_packet( ctx, stem, packet, frame.len );

FD_VOLATILE( *rx_ring->cons ) = rx_ring->cached_cons = rx_seq+1U;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a COMPILER_MFENCE here before the volatile write?

mmcgee-jump
mmcgee-jump reviewed Feb 8, 2025
View reviewed changes
src/app/fdctl/run/tiles/fd_net.c
/* Free the frame by returning it back to the fill ring */

fill_ring->frame_ring[ fill_prod&fill_mask ] = frame.addr & (~frame_mask);
FD_VOLATILE( *fill_ring->prod ) = fill_ring->cached_prod = fill_prod+1U;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also compiler_mfence here?

mmcgee-jump
mmcgee-jump requested changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@mmcgee-jump mmcgee-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ripatel-fd ripatel-fd force-pushed the ripatel/net-integration branch 3 times, most recently from 9c7dd36 to 3ed127a Compare February 9, 2025 12:58
@ripatel-fd ripatel-fd mentioned this pull request Feb 9, 2025
Closed
@ripatel-fd ripatel-fd enabled auto-merge February 9, 2025 13:25
@ripatel-fd ripatel-fd force-pushed the ripatel/net-integration branch from 07233c4 to ebf0d87 Compare February 9, 2025 13:50
riptl added 5 commits February 9, 2025 13:58
@riptl
Rewrite XDP IO in net tile
8e2a92e
@riptl
Support backpressure in net tile
729b606 
Hack requested by Tom to have more accurate pcaps.
@riptl
Remove legacy XDP code
a1d8173 
- Remove xsk_aio
- Remove xsk IO API
- Remove XDP mode from QUIC unit tests
- Remove XDP test utils
@riptl
net 2.0: new route table
c4497b5 
Adds a simple pure FIB implementation compatible with Linux
@riptl
net 2.0: netlink route importer
eb84c63
@ripatel-fd ripatel-fd force-pushed the ripatel/net-integration branch 2 times, most recently from 1d69e42 to 02b967a Compare February 9, 2025 17:07
@ripatel-fd ripatel-fd force-pushed the ripatel/net-integration branch from 02b967a to 71c7107 Compare February 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcgee-jump mmcgee-jump mmcgee-jump requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ripatel-fd @mmcgee-jump @riptl