Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS Docker containers #3915

Merged
merged 46 commits into from
Feb 6, 2025
Merged

MacOS Docker containers #3915

merged 46 commits into from
Feb 6, 2025
+336 −79

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Dec 10, 2024 •
edited
Loading

Description

Currently we only build x86 Docker containers which break on Macs.

I have confirmed that this works on the CI runners and @Ig-dolci has checked on her laptop. In both cases firedrakeproject/firedrake:latest does not run but firedrakeproject/firedrake:testing does.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real7956 ran7247 passed709 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8150 ran6597 passed1553 skipped0 failed

@connorjward connorjward force-pushed the connorjward/more-docker branch from f54961d to 2291738 Compare December 13, 2024 09:25
@connorjward connorjward marked this pull request as ready for review January 28, 2025 16:36
@connorjward connorjward requested a review from ksagiyam February 5, 2025 17:09
@ksagiyam ksagiyam merged commit 5391c50 into master Feb 6, 2025
20 checks passed
@ksagiyam ksagiyam deleted the connorjward/more-docker branch February 6, 2025 13:35
@ksagiyam
Copy link
Contributor

ksagiyam commented Feb 6, 2025

Do you know why this is happening? https://github.com/firedrakeproject/firedrake/actions/runs/13180780390/job/36790760039

@connorjward
Copy link
Contributor Author

Do you know why this is happening? https://github.com/firedrakeproject/firedrake/actions/runs/13180780390/job/36790760039

One of our workflows must be running with elevated permissions. This is almost certainly my fault. I will investigate.

@connorjward
Copy link
Contributor Author

Do you know why this is happening? https://github.com/firedrakeproject/firedrake/actions/runs/13180780390/job/36790760039

One of our workflows must be running with elevated permissions. This is almost certainly my fault. I will investigate.

My guess is that my tinkering yesterday on #4011 affected this. Whenever I see a job failing I am logging into the runners and fixing the permissions. Hopefully there shouldn't be any more but please let me know if this continues to happen.

@ksagiyam
Copy link
Contributor

ksagiyam commented Feb 6, 2025

It looks other most recent CIs are also failing for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksagiyam ksagiyam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@connorjward @ksagiyam