Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolci/fix interpolate warnings #603

Merged
merged 14 commits into from
Dec 19, 2024
Merged

Conversation

Ig-dolci
Copy link
Collaborator

@Ig-dolci Ig-dolci commented Dec 18, 2024

Gusto has several warnings related to the interpolate usage. See:

The use of `interpolate` to perform the numerical interpolation is deprecated.
  This feature will be removed very shortly.
  
  Instead, import `interpolate` from the `firedrake.__future__` module to update
  the interpolation's behaviour to return the symbolic `ufl.Interpolate` object associated
  with this interpolation.
  
  You can then assemble the resulting object to get the interpolated quantity
  of interest. For example,
  
  from firedrake.__future__ import interpolate
  ...
  
  assemble(interpolate(expr, V))

This PR seeks to fix such warnings.

@Ig-dolci Ig-dolci added the enhancement Involves adding a new capability label Dec 18, 2024
@Ig-dolci Ig-dolci marked this pull request as ready for review December 18, 2024 15:23
jshipton
jshipton previously approved these changes Dec 19, 2024
Copy link
Contributor

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"several" warnings? There were loads! Thanks so much for getting rid of them - this looks great!

Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for doing this! If I've understood, I spotted one that was maybe missed (which probably isn't picked up in our testing...)

gusto/time_discretisation/wrappers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

@tommbendall tommbendall merged commit e305589 into main Dec 19, 2024
4 checks passed
@tommbendall tommbendall deleted the dolci/fix_interpolate_warnings branch December 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Involves adding a new capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants